Merged
Conversation
…de themes There is not a lot of difference between the two purple light-mode themes. To prevent bloating the codebase, these themes are merged into one purple theme. The accent color is changed most in this situation, as the accent of `purple-rain` was previously blue. The two dark-mode themes have also been merged. This has been done to prevent complexity and having to repeat global color and color contrast fixes. The designers will continue working on an official dark-mode theme, so this might change in the future. The dark-mode will use the Maykin purple for the thematic colors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 91.81% 91.86% +0.04%
==========================================
Files 200 200
Lines 8417 8417
Branches 1238 1240 +2
==========================================
+ Hits 7728 7732 +4
+ Misses 686 682 -4
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Xaohs
approved these changes
Feb 24, 2026
Contributor
Xaohs
left a comment
Xaohs
left a comment
There was a problem hiding this comment.
As already stated, I do think we need an official dark-mode theme, but when the designers get around to this we can adjust
For now looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #284
Merging the purple light-mode themes, and merging the dark-mode themes.
There is not a lot of difference between the two purple light-mode themes. To prevent bloating the codebase, these themes are merged into one purple theme. The accent color is changed most in this situation, as the accent of
purple-rainwas previously blue.The two dark-mode themes have also been merged. This has been done to prevent complexity and having to repeat global color and color contrast fixes. This fixes the issue described in #284.
The designers will continue working on an official dark-mode theme, so this might change in the future. The dark-mode will use the Maykin purple for the thematic colors.