🐛 - fix: fixed edge case wherein the button inside of a select/dr…#300
Open
🐛 - fix: fixed edge case wherein the button inside of a select/dr…#300
Conversation
…wn could receive `width: 100%` as a child of `toolbar`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 91.86% 91.81% -0.05%
==========================================
Files 200 200
Lines 8417 8417
Branches 1239 1238 -1
==========================================
- Hits 7732 7728 -4
- Misses 682 686 +4
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svenvandescheur
requested changes
Feb 27, 2026
| } | ||
|
|
||
| // Prevent nested buttons inside selects or dropdowns from stretching | ||
| > .mykn-select .mykn-button, |
Collaborator
There was a problem hiding this comment.
Instead of adding this here, can't we filter the causing selector with a :not ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…opdown could receive
width: 100%as a child oftoolbar