Load on demands empty children cause exception

[ivan-kolesov]

version 1.8.7

I am using on-demand loading with dataUrl option as a function.
The server generates a response, and in a certain case the server may return an empty array of children.
This causes an exception (in the source code) when in

this.doLoadDataFromUrl(null, node, () => {
  this.openNodeInternal(node, slide, onFinished);
});

openNodeInternal is called.

In this state node.children has an empty array.
Is it possible to avoid trying to open a node when there are no children?

[mbraak]

I'll have a look.

[mbraak]

The call stack in the screenshot starts with open. Does the error occur when calling open?

[ivan-kolesov]

The call stack in the screenshot starts with open. Does the error occur when calling open?

This is the full stack.

[mbraak]

I cannot reproduce the error. When does the error occur? When the tree is initialized?

[ivan-kolesov]

I cannot reproduce the error. When does the error occur? When the tree is initialized?

When I open on demand a child.

[mbraak]

Ah, ok. I wasn't able to reproduce the error that way.

Is there something different in your code that might trigger the error? Maybe an option?

[ivan-kolesov]

Is there something different in your code that might trigger the error? Maybe an option?

Will try to make a sandbox

[ivan-kolesov]

Made a sandbox: https://codepen.io/ivan-kolesov/pen/poMqmVb
when try open Theropods error occurs. It seems that attribute children with empty value is the reason. Without children all correct.

[mbraak]

Thanks. I will have a look.

[mbraak]

Work in progress: #859

[mbraak]

The pr is merged. I plan to release a new version this week.

[mbraak]

The fix is in version 1.8.8.