Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle open empty folder #859

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Handle open empty folder #859

merged 2 commits into from
Nov 13, 2024

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Nov 13, 2024

Handle opening a folder without children. Fixes #858

Copy link

github-actions bot commented Nov 13, 2024

Size Change: +11 B (+0.04%)

Total Size: 28.2 kB

Filename Size Change
./lib/tree.jquery.js 5.88 kB +11 B (+0.19%)
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 863 B
./lib/dragAndDropHandler/dragElement.js 432 B
./lib/dragAndDropHandler/generateHitAreas.js 1.2 kB
./lib/dragAndDropHandler/index.js 2.19 kB
./lib/dragAndDropHandler/iterateVisibleNodes.js 547 B
./lib/dragAndDropHandler/types.js 33 B
./lib/elementsRenderer.js 1.86 kB
./lib/jqtreeMethodTypes.js 33 B
./lib/jqtreeOptions.js 33 B
./lib/keyHandler.js 813 B
./lib/mouseHandler.js 1.5 kB
./lib/mouseUtils.js 233 B
./lib/node.js 3.22 kB
./lib/nodeElement/borderDropHint.js 390 B
./lib/nodeElement/folderElement.js 832 B
./lib/nodeElement/ghostDropHint.js 548 B
./lib/nodeElement/index.js 695 B
./lib/nodeUtils.js 192 B
./lib/position.js 382 B
./lib/saveStateHandler.js 1.32 kB
./lib/scrollHandler.js 461 B
./lib/scrollHandler/containerScrollParent.js 871 B
./lib/scrollHandler/createScrollParent.js 512 B
./lib/scrollHandler/documentScrollParent.js 1.06 kB
./lib/scrollHandler/types.js 33 B
./lib/selectNodeHandler.js 622 B
./lib/simple.widget.js 954 B
./lib/util.js 347 B
./lib/version.js 146 B

compressed-size-action

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (8da7a2e) to head (3cb4d80).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #859   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          30       30           
  Lines        2288     2290    +2     
  Branches      576      577    +1     
=======================================
+ Hits         2202     2204    +2     
  Misses         86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit eb1d803 into dev Nov 13, 2024
6 checks passed
@mbraak mbraak deleted the handle-open-empty-folder branch November 13, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load on demands empty children cause exception
1 participant