Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle open empty folder #859

Merged
merged 2 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/_entries/general/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ title: Changelog
name: changelog
---

#### Development version

- Issue #858: load on demand with empty children (thanks to Ivan Kolesov)

#### 1.8.7 (november 2 2024)

- Issue #853: fix dnd to first child (thanks to Oskar von Dungern)
Expand Down
9 changes: 9 additions & 0 deletions src/test/jqTree/methods.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,15 @@ describe("openNode", () => {
});
});
});

it("handles an empty folder", () => {
const child1 = given.$tree.tree("getNodeByNameMustExist", "child1");
child1.isEmptyFolder = true;

expect(() => {
given.$tree.tree("openNode", child1, false);
}).not.toThrow();
});
});

describe("prependNode", () => {
Expand Down
4 changes: 4 additions & 0 deletions src/tree.jquery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,10 @@ export class JqTreeWidget extends SimpleWidget<JQTreeOptions> {
_slide: boolean,
_onFinished?: OnFinishOpenNode,
): void => {
if (!node.children.length) {
return;
}

const folderElement = this.createFolderElement(_node);
folderElement.open(
_onFinished,
Expand Down