Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the build and testing configuration to better support multiple architectures and improve clarity. The changes primarily affect the CI workflow, build scripts, and configuration files.
CI Workflow Updates:
.github/workflows/accelerate-manylinux.yml
: Updated the job matrix to include specific OS versions and architectures, and excluded certain combinations to avoid unnecessary builds. Also updated the naming convention for artifacts to include architecture information. [1] [2] [3]manylinux_2014 will move to 2_28. Deprecation this year 2025.
Windows arm runners are coming q2 2025.
Build Script Updates:
build-manylinux.sh
: Modified the script to dynamically set theMANYLINUX
environment variable based on the detected architecture, ensuring compatibility with both x86_64 and aarch64 architectures.Configuration Updates:
pyproject.toml
: Addedcibuildwheel
configuration to specify architectures, verbosity, test commands, and necessary environment variables for macOS builds. This ensures proper build and test setups for different architectures.