boot: Allow watchdog timeout to be configured#2131
boot: Allow watchdog timeout to be configured#2131KarlKTorp wants to merge 2 commits intomcu-tools:mainfrom
Conversation
This change adds a new Kconfig option MCUBOOT_WATCHDOG_TIMEOUT to specify the watchdog timeout value. Several devices (NXP among others) require a timeout to be installed in order to enable the watchdog. Signed-off-by: Karl Kristian Dyrholm Torp <kdt@polytech.com>
nordicjm
left a comment
There was a problem hiding this comment.
The watchdog code in mcuboot is a bit of a red herring, it does not set up a watchdog, it only feeds it. And it does not make sense to set the watchdog up every time it is fed
|
Right. That was my bad. It was of cause during setup the timeout should be installed - good catch. This is just a suggestion for the watchdog issues on NXP, we have used this method for some time. But I can see that watchdog support is limited in mcuboot and this might not be the optimal solution. That's up to you guys :) |
Signed-off-by: Karl Kristian Dyrholm Torp <kdt@polytech.com>
c1af91c to
d48f124
Compare
|
Sorry for letting this PR hang. The setup issue was fixed. Is this feature something you would consider adding? |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This change adds a new Kconfig option MCUBOOT_WATCHDOG_TIMEOUT to specify the watchdog timeout value. Several devices (NXP among others) require a timeout to be installed in order to enable the watchdog. On e.g. imxrt1170 enabling the watchdog without a timeout will print the error "No valid timeouts installed" and fail to setup the watchdog.
Fixes: #2093