This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Getting ready for 0.7/1.0 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next up: deprecations
|
I have trouble building this PR on my Julia 1.0 on macOS: (v1.0) pkg> precompile
Precompiling project...
Precompiling Crystals
[ Info: Precompiling Crystals [2c71e7ee-d617-5e33-8739-0c480ea2ee56]
WARNING: could not import Base.start into Unitful
WARNING: could not import Base.done into Unitful
WARNING: could not import Base.next into Unitful
ERROR: LoadError: LoadError: UndefVarError: endof not defined
Stacktrace:
[1] getproperty(::Module, ::Symbol) at ./sysimg.jl:13
[2] top-level scope at none:0
[3] include at ./boot.jl:317 [inlined]
[4] include_relative(::Module, ::String) at ./loading.jl:1044
[5] include at ./sysimg.jl:29 [inlined]
[6] include(::String) at /Users/qz/.julia/packages/Crystals/47RDI/src/Crystals.jl:1
[7] top-level scope at none:0
[8] include at ./boot.jl:317 [inlined]
[9] include_relative(::Module, ::String) at ./loading.jl:1044
[10] include(::Module, ::String) at ./sysimg.jl:29
[11] top-level scope at none:2
[12] eval at ./boot.jl:319 [inlined]
[13] eval(::Expr) at ./client.jl:393
[14] top-level scope at ./none:3
in expression starting at /Users/qz/.julia/packages/Crystals/47RDI/src/Structures.jl:422
in expression starting at /Users/qz/.julia/packages/Crystals/47RDI/src/Crystals.jl:29
ERROR: Failed to precompile Crystals [2c71e7ee-d617-5e33-8739-0c480ea2ee56] to /Users/qz/.julia/compiled/v1.0/Crystals/2Dg36.ji.
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1203
[3] precompile(::Pkg.Types.Context) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:514
[4] do_precompile!(::Dict{Symbol,Any}, ::Array{String,1}, ::Dict{Symbol,Any}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:662
[5] #invokelatest#1(::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:697
[6] invokelatest(::Any, ::Any, ::Vararg{Any,N} where N) at ./essentials.jl:696
[7] do_cmd!(::Pkg.REPLMode.PkgCommand, ::REPL.LineEditREPL) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:603
[8] #do_cmd#33(::Bool, ::Function, ::REPL.LineEditREPL, ::String) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:577
[9] do_cmd at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:573 [inlined]
[10] (::getfield(Pkg.REPLMode, Symbol("##50#53")){REPL.LineEditREPL,REPL.LineEdit.Prompt})(::REPL.LineEdit.MIState, ::Base.GenericIOBuffer{Array{UInt8,1}}, ::Bool) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/REPLMode.jl:923
[11] #invokelatest#1 at ./essentials.jl:697 [inlined]
[12] invokelatest at ./essentials.jl:696 [inlined]
[13] run_interface(::REPL.Terminals.TextTerminal, ::REPL.LineEdit.ModalInterface, ::REPL.LineEdit.MIState) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/REPL/src/LineEdit.jl:2273
[14] run_frontend(::REPL.LineEditREPL, ::REPL.REPLBackendRef) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:1034
[15] run_repl(::REPL.AbstractREPL, ::Any) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/REPL/src/REPL.jl:191
[16] (::getfield(Base, Symbol("##718#720")){Bool,Bool,Bool,Bool})(::Module) at ./client.jl:355
[17] #invokelatest#1 at ./essentials.jl:697 [inlined]
[18] invokelatest at ./essentials.jl:696 [inlined]
[19] run_main_repl(::Bool, ::Bool, ::Bool, ::Bool, ::Bool) at ./client.jl:339
[20] exec_options(::Base.JLOptions) at ./client.jl:277
[21] _start() at ./client.jl:425 |
|
Ah, this was all done mainly on the beta and 0.7. The new iteration scheme wasn't in place yet. Should be an easy fix, I'll have a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes I made allow all the tests and doctests to run.
No big changes were done, if I recall everything they were:
position=to atpositionwithvcatinCrystalconstructiontranspose(Matrix) !<: Matrix=>collect(transpose(Matrix))findfirst(no trues) == 0=>findfirst(no trues) == nothingI also cleared deprecations.
What doesn't work: generation of documentation itself (please help 😄)