Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django auth - cross link to logout template once logout button enabled #33195

Merged
merged 3 commits into from
May 3, 2024

Conversation

hamishwillee
Copy link
Collaborator

In mdn/django-locallibrary-tutorial#141 there is a question about whether the logout behaviour takes you to the admin logout view. It does not (if you have followed the tutorial). This makes it clear that you end up in the logout template page created earlier in this same topic/

@hamishwillee hamishwillee requested a review from a team as a code owner April 21, 2024 23:01
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team April 21, 2024 23:01
@github-actions github-actions bot added the Content:Learn:Django Learning area Django docs label Apr 21, 2024
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Apr 21, 2024
Copy link
Contributor

github-actions bot commented Apr 21, 2024

Preview URLs

(comment last updated: 2024-05-03 08:29:52)

@hamishwillee
Copy link
Collaborator Author

@teoli2003 Can I please get this merged too

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, tnx 👍🏻

@bsmth bsmth merged commit 3b19069 into main May 3, 2024
9 checks passed
@bsmth bsmth deleted the hamishwillee-patch-2 branch May 3, 2024 08:30
@hamishwillee
Copy link
Collaborator Author

Thanks @bsmth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Django Learning area Django docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants