Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exception description for HTMLDialogElement.show() and .showMo… #38054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update exception description for HTMLDialogElement.show() and .showMo… #38054

wants to merge 1 commit into from
+6 −1

Conversation

ygaj
Copy link

@ygaj ygaj commented Feb 8, 2025

Description

The current exception descriptions for HTMLDialogElement.showModal() and HTMLDialogElement.show() are outdated.

Motivation

This behavior was updated to only throw errors when switching between modes.

@ygaj ygaj requested a review from a team as a code owner February 8, 2025 21:26
@ygaj ygaj requested review from sideshowbarker and removed request for a team February 8, 2025 21:26
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Feb 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Preview URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ygaj