-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS display module / move "flow" guides under display #38091
Conversation
Preview URLs (67 pages)
Flaws (222)Note! 22 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (1)URL:
(comment last updated: 2025-02-12 07:47:28) |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle a few bits for you, but nothing major. This move makes sense.
One thing — the guides you moved under CSS_display
that were under CSS_flow_layout
are still showing in the sidebar under a "Flow layout" tree (Flow layout and writing modes, for example). Are you intending to update the sidebar?
files/en-us/web/css/css_display/block_and_inline_layout_in_normal_flow/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_display/block_formatting_context/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_display/in_flow_and_out_of_flow/index.md
Outdated
Show resolved
Hide resolved
@@ -212,7 +212,7 @@ When you do anything to remove or shift an item from where it would be placed in | |||
|
|||
## Summary | |||
|
|||
In this guide, we have covered the ways to take an element out of flow in order to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Formatting Contexts Explained](/en-US/docs/Web/CSS/CSS_flow_layout/Introduction_to_formatting_contexts). | |||
In this guide, we have covered the ways to take an element out of flow in order to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this guide, we have covered the ways to take an element out of flow in order to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts). | |
In this guide, we have explained how to take an element out of flow to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Introduction to formatting contexts](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one wasn't committed; is there a reason for using the wrong article title in the link text?
I updated the sidebar, and realized the display guide was not under css_display, so moved that too. other than the above moves, and merging your suggestions, no text edits were made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @estelle. Just a couple of comments to check on one naming point, but I don't think this is a blocker. I don't think this is a blocker, so approving.
- {{Glossary("Block/CSS", "Block (CSS)")}} | ||
- [Block and inline layout in normal flow](/en-US/docs/Web/CSS/CSS_display/Block_and_inline_layout_in_normal_flow) | ||
- [In flow and out of flow](/en-US/docs/Web/CSS/CSS_display/In_flow_and_out_of_flow) | ||
- [Formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts) | |
- [Introduction to formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find and replace, if you agree?
@@ -212,7 +212,7 @@ When you do anything to remove or shift an item from where it would be placed in | |||
|
|||
## Summary | |||
|
|||
In this guide, we have covered the ways to take an element out of flow in order to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Formatting Contexts Explained](/en-US/docs/Web/CSS/CSS_flow_layout/Introduction_to_formatting_contexts). | |||
In this guide, we have covered the ways to take an element out of flow in order to achieve some very specific types of positioning. In the next guide we will look at a related issue, that of creating a [Block Formatting Context](/en-US/docs/Web/CSS/CSS_display/Block_formatting_context), in [Formatting contexts explained](/en-US/docs/Web/CSS/CSS_display/Introduction_to_formatting_contexts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one wasn't committed; is there a reason for using the wrong article title in the link text?
update to the CSS display module.
move the CSS_flow_layout pages to be under display, as flow layout is not a module, but all the content from those guides is part of css2.1 and the display spec
The main components of this PR are:
/CSS_flow_layout
directory to be in the/CSS_display
directory.CSS display
module landing pageI did remove some content from the flow_layout main page, as it is not a module page, but while I added a couple of links and changed a couple of cases, this PR is NOT an update to any of the individual guides. That , including links, casing, and a refresh, will be in a future PR.