Skip to content

Conversation

@bsmth
Copy link
Member

@bsmth bsmth commented Dec 4, 2025

Description

Adds a reference page for baseline-source.

Motivation

This slipped through Fx release in 115.

Additional details

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner December 4, 2025 12:57
@bsmth bsmth requested review from estelle and removed request for a team December 4, 2025 12:57
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/CSS/Guides/Inline_layout
Title: CSS inline layout
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/CSS/baseline-shift

URL: /en-US/docs/Web/CSS/Reference/Properties/baseline-source
Title: baseline-source
Flaw count: 2

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
    • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect

(comment last updated: 2025-12-05 13:24:26)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback for your consideration

@bsmth bsmth requested a review from estelle December 4, 2025 14:48
@bsmth
Copy link
Member Author

bsmth commented Dec 4, 2025

Thanks, @estelle should be good for another look now 👀

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values as DL
test suggestions to reduce congnitive load, which includes adding an
intro sentence to HTML

approving to not hold you up

@bsmth bsmth merged commit caab35a into mdn:main Dec 5, 2025
8 checks passed
@bsmth bsmth deleted the baseline-source branch December 5, 2025 13:24
@bsmth
Copy link
Member Author

bsmth commented Dec 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants