Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-230 | Overview - Planets list summary refactor #235

Merged
merged 7 commits into from
Jul 6, 2022
Merged

GH-230 | Overview - Planets list summary refactor #235

merged 7 commits into from
Jul 6, 2022

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Jul 6, 2022

Summary:

Planets list summary (at the bottom of the Overview), currently placed in overview.php, should have its own (sub)module.

Changelog:

  • Move Planets list element code to its own (sub)module
  • Use flexbox instead of PHP to display planets in rows
  • Use existing functions to parse buildings queue

Related issues or PRs:

#230

@mdziekon mdziekon added the pr:refactor All pull requests containing code refactors label Jul 6, 2022
@mdziekon mdziekon merged commit 4687ac7 into master Jul 6, 2022
@mdziekon mdziekon deleted the gh-230-overview-components-refactor branch July 6, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:refactor All pull requests containing code refactors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdziekon