Skip to content

Commit

Permalink
fix(frontend): hide filter pill when no span statuses are selected
Browse files Browse the repository at this point in the history
fixes #1763
  • Loading branch information
anupcowkur committed Jan 22, 2025
1 parent f763ac3 commit b02859d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion frontend/dashboard/app/components/filters.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ const Filters: React.FC<FiltersProps> = ({
{showDates && <FilterPill title={`${selectedFormattedStartDate} to ${selectedFormattedEndDate}`} />}
{showAppVersions && selectedVersions.length > 0 && <FilterPill title={Array.from(selectedVersions).map((v) => v.displayName).join(', ')} />}
{showSessionType && <FilterPill title={selectedSessionType} />}
{filtersApiType === FiltersApiType.Span && <FilterPill title={Array.from(selectedSpanStatuses).join(', ')} />}
{filtersApiType === FiltersApiType.Span && selectedSpanStatuses.length > 0 && <FilterPill title={Array.from(selectedSpanStatuses).join(', ')} />}
{showOsVersions && selectedOsVersions.length > 0 && <FilterPill title={Array.from(selectedOsVersions).map((v) => v.displayName).join(', ')} />}
{showCountries && selectedCountries.length > 0 && <FilterPill title={Array.from(selectedCountries).join(', ')} />}
{showNetworkProviders && selectedNetworkProviders.length > 0 && <FilterPill title={Array.from(selectedNetworkProviders).join(', ')} />}
Expand Down

0 comments on commit b02859d

Please sign in to comment.