Skip to content

fix(frontend): fix nav aside scroll on detail content exceeding screen area #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix(frontend): fix nav aside scroll on detail content exceeding screen area #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/dashboard/__tests__/components/__snapshots__/filter_pill_test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`FilterPill renders correctly 1`] = `
TITLE
</p>
<span
class="pointer-events-none z-50 max-w-xl absolute font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 -top-2 transform translate-y-full w-max opacity-0 transition-opacity group-hover:opacity-100"
class="pointer-events-none z-50 absolute max-w-xl w-max font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 top-0 transform translate-y-8 opacity-0 transition-opacity group-hover:opacity-100"
>
TITLE
</span>
Expand All @@ -31,7 +31,7 @@ exports[`FilterPill renders correctly 1`] = `
TITLE
</p>
<span
class="pointer-events-none z-50 max-w-xl absolute font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 -top-2 transform translate-y-full w-max opacity-0 transition-opacity group-hover:opacity-100"
class="pointer-events-none z-50 absolute max-w-xl w-max font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 top-0 transform translate-y-8 opacity-0 transition-opacity group-hover:opacity-100"
>
TITLE
</span>
Expand Down
2 changes: 1 addition & 1 deletion frontend/dashboard/app/[teamId]/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export default function DashboardLayout({
<button className="m-4 outline-none flex justify-center hover:bg-yellow-200 active:bg-yellow-300 focus-visible:bg-yellow-200 border border-black rounded-md font-display transition-colors duration-100 py-2 px-4" onClick={() => logoutUser()}>Logout</button>
</nav>
</aside>
{teamsApiStatus === TeamsApiStatus.Success && <main>{children}</main>}
{teamsApiStatus === TeamsApiStatus.Success && <main className="md:overflow-auto">{children}</main>}
</div>
</div>
);
Expand Down
6 changes: 4 additions & 2 deletions frontend/dashboard/app/components/filter_pill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,16 @@ interface FilterPillProps {
title: string,
}

const tooltipChars = 1000

const FilterPill: React.FC<FilterPillProps> = ({ title }) => {
return (
<div className="group relative select-none">
<p className="px-2 py-1 max-w-72 whitespace-nowrap text-ellipsis overflow-hidden text-white bg-neutral-950 font-display text-sm border border-black rounded-full outline-none transition ease-in-out transition-colors duration-100">
{title}
</p>
<span className="pointer-events-none z-50 max-w-xl absolute font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 -top-2 transform translate-y-full w-max opacity-0 transition-opacity group-hover:opacity-100">
{title}
<span className="pointer-events-none z-50 absolute max-w-xl w-max font-sans text-xs text-white rounded-md p-4 bg-neutral-800 left-0 top-0 transform translate-y-8 opacity-0 transition-opacity group-hover:opacity-100">
{title.length <= tooltipChars ? title : title.slice(0, tooltipChars) + "..."}
</span>
</div>
);
Expand Down
1 change: 0 additions & 1 deletion frontend/dashboard/app/components/filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import DropdownSelect, { DropdownSelectType } from "./dropdown_select";
import FilterPill from "./filter_pill";
import CreateApp from "./create_app";
import DebounceTextInput from "./debounce_text_input";
import LoadingSpinner from "./loading_spinner";

export enum AppVersionsInitialSelectionType {
Latest,
Expand Down