-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): attach layout snapshots with gesture click events #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
588aaa1
to
d89fa58
Compare
d89fa58
to
5208ff7
Compare
5208ff7
to
281c38a
Compare
281c38a
to
1264bd2
Compare
1264bd2
to
8f317be
Compare
8f317be
to
25d4e62
Compare
25d4e62
to
3d5e8ab
Compare
49b73fe
to
f5d7b35
Compare
f5d7b35
to
6b3aea5
Compare
6b3aea5
to
d5c5a87
Compare
d5c5a87
to
3900aa1
Compare
3900aa1
to
a93d42f
Compare
a93d42f
to
751e739
Compare
detj
approved these changes
Dec 8, 2024
751e739
to
4e3bcdc
Compare
* reimplement gesture tracking algorithm to also create a layout snapshot in a single pass * implement a reusable layout inspector * update benchmarks * refactor event processor interface to simplify the overloaded track functions * update benchmark scrips for new gesture tracking benchmarks * delete gestures benchmarks for previous implementation * add sample sessions with SVG attachments
4e3bcdc
to
6268aa2
Compare
6268aa2
to
7c03a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a summary of the changes
Changes
android
: Reimplement gesture tracking algorithm to also create a layout snapshot in a single passandroid
: Implement a reusable layout inspectorandroid
: Update benchmarksandroid
: Refactor event processor interface to simplify the overloaded track functionsandroid
: Update benchmark scrips for new gesture tracking benchmarksandroid
: Delete gestures benchmarks for previous implementationbackend
: Add sample sessions with SVG attachmentsbackend
: Add a new attachment typelayout_snapshot
.frontend
: Show attachment for gesture click eventsRelated issue
Closes #1311