Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-shell 3.36.1 compatibility #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jcarle
Copy link

@jcarle jcarle commented May 9, 2020

No description provided.

@jcarle
Copy link
Author

jcarle commented May 9, 2020

I have tried to fix the errors that occur in gnome-shell 3.36.1
Please check if it's ok.

Thank you

@RandieM
Copy link

RandieM commented Jun 14, 2020

It works on Fedora 32/Gnome 3.36.2.

@nicjohnston
Copy link

nicjohnston commented Sep 1, 2020

Unfortunately this stopped working with Gnome 3.36.4 on Debian testing.
The extension loads, and seems to allow window selection, but doesn't display anything.
Checking the logs shows the following error message being generated when selecting a window to preview.

gnome-shell[3009]: JS ERROR: TypeError: this._container.foreach is not a function
    _setThumbnail@/home/nic/.local/share/gnome-shell/extensions/[email protected]/preview.js:410:25
    set window@/home/nic/.local/share/gnome-shell/extensions/[email protected]/preview.js:633:14
    _onUserTriggered/</</<@/home/nic/.local/share/gnome-shell/extensions/[email protected]/indicator.js:141:21
    activate@resource:///org/gnome/shell/ui/popupMenu.js:191:14
    vfunc_button_release_event@resource:///org/gnome/shell/ui/popupMenu.js:138:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants