feat: Add support for product export in UI #8281

sradevski · 2024-07-25T11:28:14Z

I've keep the PR simple, so it is missing column selection (we should discuss if we event want it now or in the polish stage) and push notifications (similarly, needs discussion if we want to tackle it right away).

One thing we need to improve (outside of the scope here) is to preserve query params on handleSuccess call, so filters and such is not lost if you eg. go to create and go back.

CLOSES CC-234

changeset-bot · 2024-07-25T11:28:18Z

⚠️ No Changeset found

Latest commit: 0d4099f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-07-25T11:28:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 29, 2024 6:31pm

6 Skipped Deployments

Name	Status	Preview	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)		Jul 29, 2024 6:31pm
api-reference-v2	⬜️ Ignored (Inspect)	Visit Preview	Jul 29, 2024 6:31pm
docs-ui	⬜️ Ignored (Inspect)	Visit Preview	Jul 29, 2024 6:31pm
docs-v2	⬜️ Ignored (Inspect)	Visit Preview	Jul 29, 2024 6:31pm
medusa-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 29, 2024 6:31pm
resources-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 29, 2024 6:31pm

sradevski · 2024-07-25T11:28:40Z

packages/admin-next/dashboard/src/components/table/data-table/data-table-filter/date-filter.tsx

+        onRemove={handleRemove}
+        readonly={readonly}
+      />
+      {!readonly && (


These are just indentation changes, no actual code changed other than the readonly check.

sradevski · 2024-07-25T11:32:17Z

...admin-next/dashboard/src/components/table/data-table/data-table-filter/data-table-filter.tsx

+  filters,
+  readonly,
+  prefix,
+}: DataTableFilterProps) => {
  const { t } = useTranslation()
  const [searchParams] = useSearchParams()
  const [open, setOpen] = useState(false)


Question: Can't we rely solely on the query parameters for the activeFilters state? I feel like it should be possible, and we can remove some code around maintaining their state (so basically we have getInitialFilters be the state, and that gets memoized with location.search passed to it)

olivermrbl · 2024-07-28T08:01:33Z

/snapshot-this

olivermrbl · 2024-07-28T08:57:56Z

@sradevski, this doesn't seem to work-out-of-the box with the local file provider – did you use S3?

The exported CSV file is put into the /private folder, which is not served by the server as far as I can see. To be downloadable from admin, this should be placed in static no?

Update: Perhaps the issue is also related to the fact that the generated URL of the exported file points to a path on the local file system and not one on the server. Not sure if our Vite application can deal with this?

sradevski · 2024-07-28T14:20:28Z

@olivermrbl That behavior is intentional actually. The problem with using the local file provider for the exports is that we can't have security controls (so, no support for private files) if we put it in static, as anyone would be able to read the file, so I create a private folder where private files would go (and you would need direct access to the machine to fetch them).

Let me know if you think this should behave differently, it's super easy to change it.

olivermrbl · 2024-07-28T14:22:24Z

The problem with using the local file provider for the exports is that we can't have security controls (so, no support for private files) if we put it in static, as anyone would be able to read the file

Given the local file provider is only used for development, wouldn't this be OK?

sradevski · 2024-07-28T14:44:40Z

The problem with using the local file provider for the exports is that we can't have security controls (so, no support for private files) if we put it in static, as anyone would be able to read the file

Given the local file provider is only used for development, wouldn't this be OK?

I've heard people use it in production as well for some small sites, so I thought to err on the safe side. If we are OK with it since people really shouldn't use it in prod, then we can def. put it in static. WDYT?

You can actually configure if you want it in static or private currently (you just need to set privateUploadDir_ to the same URL as uploadDir_), but it defaults to private. Maybe we can default to static instead?

olivermrbl · 2024-07-28T14:54:39Z

You can actually configure if you want it in static or private currently (you just need to set privateUploadDir_ to the same URL as uploadDir_), but it defaults to private. Maybe we can default to static instead?

Originally (in V1), the provider was supposed to be for development only, and IMO, this should still be the recommendation from our side. With that in mind, I would suggest we optimize for this use case such that we can guarantee a good first experience across all our features.

Then in the rare (my hunch; how often have you heard this being used in prod?) case, we can guide developers to a secure configuration with the local provider.

Wdyt?

sradevski · 2024-07-28T14:56:55Z

@olivermrbl it should definitely be only for development, but I've seen at least 2 conversations on Discord, and one from a local agency (and I obviously told them to use S3 😄).

Then let me use the same, static directory for private files as well, and leave a comment that if they really wanted to they can change it through the config, WDYT?

olivermrbl · 2024-07-28T14:58:28Z

Then let me use the same, static directory for private files as well, and leave a comment that if they really wanted to they can change it through the config, WDYT?

Sounds good!

olivermrbl · 2024-07-29T12:08:56Z

@sradevski, the static folder is correctly used now for the file uploads. However, we still have the issue with the admin dashboard attempting to download from the local file system. This leads to the download containing the index.html because that's the fallback in case the requested file cannot be found.

olivermrbl · 2024-07-29T16:44:04Z

@kasperkristensen, could you give this a review? 🙏

sradevski · 2024-07-29T17:16:42Z

@olivermrbl I missed removing one check (see last commit), should be good now.

olivermrbl

LGTM!

olivermrbl · 2024-07-29T19:50:00Z

@sradevski, works nicely – good one 👍

sradevski requested a review from a team as a code owner July 25, 2024 11:28

sradevski requested review from riqwan, fPolic and kasperkristensen July 25, 2024 11:28

github-actions bot added the team: medusa label Jul 25, 2024

sradevski commented Jul 25, 2024

View reviewed changes

sradevski force-pushed the feat/add-support-export-product-ui branch from f16386d to ae11951 Compare July 26, 2024 08:33

vercel bot deployed to Preview – medusa-dashboard July 26, 2024 08:34 View deployment

sradevski mentioned this pull request Jul 26, 2024

feat: Add support for product imports #8298

Merged

olivermrbl added the type: feature label Jul 28, 2024

sradevski force-pushed the feat/add-support-export-product-ui branch from ae11951 to 0c20399 Compare July 29, 2024 09:44

vercel bot deployed to Preview – medusa-dashboard July 29, 2024 09:46 View deployment

sradevski force-pushed the feat/add-support-export-product-ui branch from 0c20399 to b22d407 Compare July 29, 2024 17:16

vercel bot deployed to Preview – medusa-dashboard July 29, 2024 17:17 View deployment

sradevski force-pushed the feat/add-support-export-product-ui branch from b22d407 to 9b833b2 Compare July 29, 2024 17:32

vercel bot deployed to Preview – medusa-dashboard July 29, 2024 17:33 View deployment

sradevski added 2 commits July 29, 2024 21:30

feat: Add support for product export in UI

b1b4ae8

fix:Return the backend URL for private files of local file provider

0d4099f

sradevski force-pushed the feat/add-support-export-product-ui branch from 9b833b2 to 0d4099f Compare July 29, 2024 18:30

vercel bot deployed to Preview – medusa-dashboard July 29, 2024 18:31 View deployment

olivermrbl approved these changes Jul 29, 2024

View reviewed changes

olivermrbl merged commit b539c6d into develop Jul 29, 2024
23 checks passed

olivermrbl deleted the feat/add-support-export-product-ui branch July 29, 2024 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for product export in UI #8281

feat: Add support for product export in UI #8281

sradevski commented Jul 25, 2024 •

edited

Loading

changeset-bot bot commented Jul 25, 2024 •

edited

Loading

vercel bot commented Jul 25, 2024 •

edited

Loading

sradevski Jul 25, 2024

sradevski Jul 25, 2024

olivermrbl commented Jul 28, 2024

olivermrbl commented Jul 28, 2024 •

edited

Loading

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

olivermrbl commented Jul 29, 2024

olivermrbl commented Jul 29, 2024

sradevski commented Jul 29, 2024

olivermrbl left a comment

olivermrbl commented Jul 29, 2024

feat: Add support for product export in UI #8281

feat: Add support for product export in UI #8281

Conversation

sradevski commented Jul 25, 2024 • edited Loading

changeset-bot bot commented Jul 25, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Jul 25, 2024 • edited Loading

sradevski Jul 25, 2024

Choose a reason for hiding this comment

sradevski Jul 25, 2024

Choose a reason for hiding this comment

olivermrbl commented Jul 28, 2024

olivermrbl commented Jul 28, 2024 • edited Loading

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

sradevski commented Jul 28, 2024

olivermrbl commented Jul 28, 2024

olivermrbl commented Jul 29, 2024

olivermrbl commented Jul 29, 2024

sradevski commented Jul 29, 2024

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl commented Jul 29, 2024

sradevski commented Jul 25, 2024 •

edited

Loading

changeset-bot bot commented Jul 25, 2024 •

edited

Loading

vercel bot commented Jul 25, 2024 •

edited

Loading

olivermrbl commented Jul 28, 2024 •

edited

Loading