Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md #11

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Update pull_request_template.md #11

merged 3 commits into from
Oct 3, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Sep 19, 2022 •
edited
Loading

@curquiza curquiza mentioned this pull request Sep 19, 2022
Open
@curquiza
Copy link
Member Author

@ferdi05 @brunoocasali and @CaroFG
I also created a dedicated section in the PR to encourage PR filling it!

@curquiza curquiza marked this pull request as ready for review September 21, 2022 15:23
ferdi05
ferdi05 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@ferdi05 ferdi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I don't want to be the only reviewer

@curquiza curquiza requested a review from dichotommy September 21, 2022 15:26
@curquiza
Copy link
Member Author

I also put @dichotommy as review since your are concerned

brunoocasali
brunoocasali approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :)

dichotommy
dichotommy approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@dichotommy dichotommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌊🏄🏻

@curquiza curquiza merged commit 70a6140 into main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdi05 ferdi05 ferdi05 approved these changes

@brunoocasali brunoocasali brunoocasali approved these changes

@CaroFG CaroFG CaroFG approved these changes

@dichotommy dichotommy dichotommy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curquiza @ferdi05 @brunoocasali @CaroFG @dichotommy