Fix compilation when vietnamese feature is disabled #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2024
irevoire
approved these changes
Jan 30, 2024
|
Build succeeded:
|
No problem. Thank you for quickly approving and merging. This can be mitigated in the future by testing without default features on CI. |
meili-bors bot
added a commit
that referenced
this pull request
Jan 30, 2024
261: Fix unused FstSegmenter warning when not using khmer compiler features r=irevoire a=timvisee # Pull Request ## Related issue Fixes <#260> Depends on <#259> ## What does this PR do? - Fixes compilation warnings without `thai` or `khmer` features - Puts related module behind conditional feature attribute ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: timvisee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #258
What does this PR do?
vietnamesefeaturePR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!