-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametric TLS for read transactions #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c52f919
to
053c778
Compare
7d3e965
to
d60ea76
Compare
d60ea76
to
4faa7bc
Compare
9e7fe3e
to
74fe024
Compare
Kerollmops
commented
Dec 19, 2024
67b5380
to
53e8319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a breaking change to the
RoTxn
type, allowing it to be eitherSend
or!Send
without toggling a feature flag. This is useful when using both sendable and non-sendableRoTxn
s in the same application. Non-sendableRoTxn
s are known to be faster as they require less to no allocation.To Do
EncryptedEnv
.WithTls
andWithoutTls
type parameters.WithoutTls
makesRoTxn
Send andWithTls
makes them!Send
.Env
and that it follows the following rules.WithTls
by default.(optional) Make it possible to recycle the.RoTxn
by using themdb_txn_reset
function