Bump LMDB commit, use GitLab for LMDB and improve the build script #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
force-pushed
the
update-lmdb-and-build-script
branch
from
9d43657 to
00ea6d9
Compare
Kerollmops
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the LMDB
mdb.masterandmdb.master3branches to fix ITS#10296 (fix commit to be durable on macOS), among other things. I switched to using GitLab to pull LMDB and also ensure the build script is rerun when the LMDB source files change.This PR will land when the macOS CI passes, and it will pass only when my PATCH over the @hyc invalid typo fix on my PATCH will land on the mainstream LMDB repository.Done in b21e1b9f.