Stabilize vector store usage #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strift
changed the base branch from
bump-meilisearch-v1.3.0
to
bump-meilisearch-v1.13
ahmednfwela
requested changes
Feb 8, 2025
| @@ -542,19 +541,11 @@ void main() { | |||
| }); | |||
|
|
|||
| // Commented because of https://github.com/meilisearch/meilisearch-dart/issues/369 | |||
| group('Experimental', () { | |||
| group('Vector search', () { | |||
There was a problem hiding this comment.
this test is now failing
There was a problem hiding this comment.
because we still use the old meilisearch version
|
This PR attempts to make vector search part of the stable features and remove This triggered an internal error in Meilisearch (see tests). I'll report to the meilisearch team in the meantime. |
|
The issue was an internal issue with meilisearch that I reported here. Still, I managed to fix the tests and they now work with v1.13.0. |
|
Build succeeded: |
meili-bors bot
added a commit
that referenced
this pull request
Feb 18, 2025
411: Update version for the next release (v0.17) r=Strift a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-dart to a new version: "v0.17" 👇 CHANGELOG ## ✨ New * [AI-powered search](https://www.meilisearch.com/docs/learn/ai_powered_search/getting_started_with_ai_search) is now stable `@/Strift` ## 🚀 Enhancements * implement experimental ai-powered search (#398) `@/memishood` * Rename current_mean and current_sigma for AI feature (#407) `@/ahmednfwela` * Stabilize vector store usage (#410) `@/Strift` * Changes related to the next Meilisearch release (v1.13) (#408) `@/Strift` ## ⚙️ Maintenance/misc * Chore: fix linting issues (#403) `@/Strift` * Revert "Chore: fix linting issues" & fix linting (#405) `@/curquiza` Thanks again to `@/Strift,` `@/ahmednfwela,` `@/curquiza,` `@/meili-bors[bot],` and `@memishood!` 🎉 Co-authored-by: meili-bot <[email protected]> Co-authored-by: Laurent Cazanove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #409
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!