Skip to content

Commit

Permalink
Merge #696
Browse files Browse the repository at this point in the history
696: Add all-args-constructor for easy initial config Pagination r=curquiza a=jonaskahn

# Pull Request for Enhancement

## What does this PR do?
This is a tiny PR to make the Pagination initial more easier.
The current implementation make extra lines to config Pagination. Here is an example:

**Before**
```Kotlin
val index = meilisearchClient.index(it.getIndex())
val defaultPagination = Pagination()
defaultPagination.maxTotalHits = 5000
index.updatePaginationSettings(defaultPagination)
```
**After**
```Kotlin
val index = meilisearchClient.index(it.getIndex())
index.updatePaginationSettings(Pagination(5000))
```

Co-authored-by: Jonas <[email protected]>
Co-authored-by: Clémentine U. - curqui <[email protected]>
Co-authored-by: Jonas Kahn <[email protected]>
  • Loading branch information
3 people authored Jan 29, 2024
2 parents 3bea276 + 4719d74 commit 02068d5
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/main/java/com/meilisearch/sdk/model/Pagination.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@ public class Pagination {
protected int maxTotalHits;

public Pagination() {}

public Pagination(int maxTotalHits) {
this.maxTotalHits = maxTotalHits;
}
}
32 changes: 32 additions & 0 deletions src/test/java/com/meilisearch/integration/SettingsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,38 @@ public void testUpdatePaginationSettings() throws Exception {
assertThat(updatedPagination.getMaxTotalHits(), is(equalTo(100)));
}

@Test
@DisplayName("Test initial pagination settings with param")
public void testInitialPaginationSettingsWithParam() throws Exception {
Index index = createIndex("testInitialPaginationSettingsWithParam");

int MaxTotalHitsTypos = 100;
Pagination newPagination = new Pagination(MaxTotalHitsTypos);
index.waitForTask(index.updatePaginationSettings(newPagination).getTaskUid());
Pagination updatedPagination = index.getPaginationSettings();

assertThat(updatedPagination.getMaxTotalHits(), is(equalTo(100)));
}

@Test
@DisplayName("Test reset pagination settings when constructor with param")
public void testResetPaginationSettingsWhenConstructorWithParam() throws Exception {
Index index = createIndex("testResetPaginationSettingsWhenConstructorWithParam");

Pagination initialPagination = index.getPaginationSettings();
int MaxTotalHitsTypos = 100;
Pagination newPagination = new Pagination(MaxTotalHitsTypos);
index.waitForTask(index.updatePaginationSettings(newPagination).getTaskUid());
Pagination updatedPagination = index.getPaginationSettings();

index.waitForTask(index.resetPaginationSettings().getTaskUid());
Pagination paginationAfterReset = index.getPaginationSettings();

assertThat(initialPagination.getMaxTotalHits(), is(equalTo(1000)));
assertThat(updatedPagination.getMaxTotalHits(), is(equalTo(100)));
assertThat(paginationAfterReset.getMaxTotalHits(), is(equalTo(1000)));
}

@Test
@DisplayName("Test reset pagination settings")
public void testResetPaginationSettings() throws Exception {
Expand Down

0 comments on commit 02068d5

Please sign in to comment.