Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinct search parameter support added #785

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Distinct search parameter support added #785

merged 9 commits into from
Nov 6, 2024

Conversation

Barabasbalazs
Copy link
Contributor

@Barabasbalazs Barabasbalazs commented Oct 25, 2024 •
edited
Loading

Pull Request

Related issue

Fixes #756

What does this PR do?

  • Added support for using the distinct keyword in the java client. Updated tests and code samples accordingly.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza
Copy link
Member

curquiza commented Nov 6, 2024 •
edited
Loading

@Barabasbalazs can you fix the linter test before I review?

Thank you for your PR

@Barabasbalazs
Copy link
Contributor Author

@curquiza fixed the linting issue, also merged in the changes from main

curquiza
curquiza approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 6, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 031d9db into meilisearch:main Nov 6, 2024
3 checks passed
@curquiza curquiza added the enhancement New feature or request label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.9] Accept distinct search parameter
2 participants
@Barabasbalazs @curquiza