Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support facet distribution for federated search #792

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Support facet distribution for federated search #792

merged 6 commits into from
Nov 27, 2024

Conversation

Barabasbalazs
Copy link
Contributor

Pull Request

Related issue

Fixes #787

What does this PR do?

  • Adds support for federation.facetsByIndex in the POST /multi-search route.
  • Allows for merging of returned facets with federation.mergeFacets in the POST /multi-search route

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Barabasbalazs Barabasbalazs marked this pull request as draft November 12, 2024 06:27
@Barabasbalazs Barabasbalazs marked this pull request as ready for review November 12, 2024 09:16
@curquiza curquiza added the enhancement New feature or request label Nov 27, 2024
curquiza
curquiza approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you ❤️

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Nov 27, 2024

Build succeeded:

  • integration-and-unit-tests
  • linter

@meili-bors meili-bors bot merged commit 032deec into meilisearch:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.11.0] Support facet distribution for federated search
2 participants
@Barabasbalazs @curquiza