Merge #592

592: Fix hubspot form build r=Strift a=Strift

This PR:
- Add default values for Hubspot form
- Add a `prebuild` script that checks that the env are available
- Bump version to create a new release


Co-authored-by: Strift <[email protected]>

.env

@@ -0,0 +1,3 @@
+# Hubspot newsletter
+REACT_APP_HUBSPOT_PORTAL_ID=25945010
+REACT_APP_HUBSPOT_FORM_GUID=991e2a09-77c2-4428-9242-ebf26bfc6c64

cypress/e2e/side-panel.cy.js

@@ -1,3 +1,5 @@
+const WAITING_TIME = Cypress.env('waitingTime')
+
 describe(`Right side panel`, () => {
   beforeEach(() => {
     cy.saveApiTokenCookie()
@@ -18,4 +20,13 @@ describe(`Right side panel`, () => {
     cy.get('button[aria-label="Open Panel"]').click()
     cy.get('[data-testid="right-panel"]').should('be.visible')
   })
+
+  it('Should allow subscribing to the newsletter', () => {
+    cy.get('input[placeholder="Enter your email"]').type('[email protected]')
+    cy.get('button[aria-label="Subscribe"]').click()
+    cy.wait(WAITING_TIME)
+    cy.get('[data-testid="right-panel"]').within(() => {
+      cy.get('p').should('contain', 'Thanks for subscribing!')
+    })
+  })
 })

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mini-dashboard",
-  "version": "0.2.17",
+  "version": "0.2.18",
   "private": true,
   "dependencies": {
     "@meilisearch/instant-meilisearch": "0.24",
@@ -22,8 +22,9 @@
   },
   "scripts": {
     "version-script": "node version-script.js",
-    "prestart": "yarn version-script",
-    "prebuild": "yarn version-script",
+    "validate-env": "node validate-env.js",
+    "prestart": "yarn version-script && yarn validate-env",
+    "prebuild": "yarn version-script && yarn validate-env",
     "start": "react-scripts start",
     "start:ci": "REACT_APP_MEILI_SERVER_ADDRESS=http://meilisearch:7700 react-scripts start",
     "build": "react-scripts build",

src/components/NewsletterForm.jsx

@@ -127,7 +127,11 @@ const NewsletterForm = () => {
         required
         style={{ marginTop: '0rem' }}
       />
-      <Button type="submit" disabled={status === 'loading'}>
+      <Button
+        type="submit"
+        disabled={status === 'loading'}
+        aria-label="Subscribe"
+      >
         {status === 'loading' ? (
           <>
             <SpinningIcon>

src/version/version.js

@@ -1 +1 @@
-export default '0.2.17'
+export default '0.2.18'

validate-env.js

@@ -0,0 +1,13 @@
+/* eslint-disable no-console */
+
+const requiredEnv = ['REACT_APP_API_URL', 'REACT_APP_ANOTHER_ENV_VAR']
+
+const missingEnv = requiredEnv.filter((env) => !process.env[env])
+
+if (missingEnv.length > 0) {
+  console.error(
+    `Missing required environment variables: ${missingEnv.join(', ')}`
+  )
+  process.exit(1)
+}
+console.log('All required environment variables are set.')