Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .nvmrc #574

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Add .nvmrc #574

merged 2 commits into from
Jan 20, 2025

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Jan 20, 2025

Pull Request

Related issue

Add .nvmrc to make it clear which version of Node should be used

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift added the maintenance Issue about maintenance (CI, tests, refacto...) label Jan 20, 2025
@Strift Strift requested a review from mdubus January 20, 2025 10:44
mdubus
mdubus approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕 🌻

@Strift Strift merged commit 888566b into main Jan 20, 2025
4 checks passed
@Strift Strift deleted the chore/add-nvmrc branch January 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus approved these changes

Assignees
No one assigned
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strift @mdubus