fix MAX_BATCH_SIZE const #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
approved these changes
Mar 5, 2025
|
Made a new v0.2.6 release here with your change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Solved issue
Wrong limit of MAX_BATCH_SIZE causes 400 error on sending data when the batch is fully loaded.
HTTP status client error (400 Bad Request) for url (https://api.segment.io/v1/batch)What does this PR do?
Replaced MAX_BATCH_SIZE value from 512 to 500 according the docs limit of 500 KB.
https://segment.com/docs/connections/sources/catalog/libraries/server/http-api/