Support OPUS #24
Open
Support OPUS #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
force-pushed
the
support-opus
branch
from
435679e to
8b8c77e
Compare
FelonEkonom
force-pushed
the
support-opus
branch
from
75ceb17 to
fd0a686
Compare
varsill
reviewed
Jan 22, 2025
c_src/membrane_agora_plugin/sink.cpp
Outdated
| @@ -24,7 +24,7 @@ UNIFEX_TERM create(UnifexEnv *env, char *appId, char *token, char *channelId, | |||
| scfg.enableVideo = true; | |||
| scfg.useStringUid = false; | |||
| if (state->service->initialize(scfg) != agora::ERR_OK) { | |||
| AG_LOG(ERROR, "Failed to initialize service"); | |||
| AG_LOG(ERROR, "Failed to initialize sink service"); | |||
There was a problem hiding this comment.
Suggested change
| AG_LOG(ERROR, "Failed to initialize sink service"); | |
| AG_LOG(ERROR, "Failed to initialize Agora service in sink"); |
c_src/membrane_agora_plugin/sink.cpp
Outdated
Comment on lines
160
to
164
| if (codec == CODEC_AUDIO_AAC) { | ||
| audioFrameInfo.codec = agora::rtc::AUDIO_CODEC_TYPE::AUDIO_CODEC_AACLC; | ||
| } else if (codec == CODEC_AUDIO_OPUS) { | ||
| audioFrameInfo.codec = agora::rtc::AUDIO_CODEC_TYPE::AUDIO_CODEC_OPUS; | ||
| } |
There was a problem hiding this comment.
[NIT] I would warn if other codec was passed here. I know that now the only options for CodecAudio are CODEC_AUDIO_AAC and CODEC_AUDIO_OPUS, but it might cause trouble in the future if we were to add some further codecs.
lib/agora/agora_sink.ex
Outdated
| state.native_state | ||
| ) | ||
|
|
||
| {[], %{state | native_state: native_state}} | ||
| end | ||
|
|
||
| @impl true | ||
| def handle_stream_format(Pad.ref(:audio, _id), %Opus{}, _ctx, state) do | ||
| # audio stream format will be updated in handle_buffer/4 |
There was a problem hiding this comment.
[NIT] this comment is quite ambiguos for me
lib/agora/agora_sink.ex
Outdated
| end | ||
|
|
||
| state = | ||
| if stream_format == :opus and buffer.metadata.duration != state.last_frame_duration do |
There was a problem hiding this comment.
metadata.duration isn't available outside of our pipeline, we add it with DurationAddingFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.