Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples #104

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix examples #104

merged 2 commits into from
Mar 5, 2024

Conversation

gBillal
Copy link
Contributor

@gBillal gBillal commented Feb 27, 2024

In this PR:

  • Use membrane_h26x_plugin and make it only available on test env.
  • Get width and height from H265 format in cmaf muxer
  • Fix examples by adding start_link since it's not generated anymore by Membrane.Pipeline

@gBillal gBillal requested a review from mat-hek as a code owner February 27, 2024 10:49
@mat-hek
Copy link
Member

mat-hek commented Mar 5, 2024

Hi @gBillal, thanks for the fixes! It seems you updated Credo and it's not passing now, please either downgrade or fix the warnings, thanks

@gBillal
Copy link
Contributor Author

gBillal commented Mar 5, 2024

@mat-hek fixed

@mat-hek mat-hek merged commit 25a9aae into membraneframework:master Mar 5, 2024
@gBillal gBillal deleted the fix-examples branch March 5, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Smackore
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gBillal @mat-hek