Support AVC3 #113
Merged
Support AVC3 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
force-pushed
the
isom-avc3
branch
2 times, most recently
from
3d6bfd2 to
31d5d22
Compare
varsill
requested changes
Aug 7, 2024
| @@ -40,7 +40,7 @@ defmodule Membrane.MP4.Demuxer.ISOM do | |||
| any_of( | |||
| %Membrane.AAC{config: {:esds, _esds}}, | |||
| %Membrane.H264{ | |||
| stream_structure: {:avc1, _dcr}, | |||
| stream_structure: {_avc, _dcr}, | |||
There was a problem hiding this comment.
We should assert on _avc being either :avc1 or :avc3
lib/membrane_mp4/muxer/isom.ex
Outdated
| state | ||
|
|
||
| # otherwise we can assume that output will be corrupted | ||
| true -> | ||
| raise "ISOM Muxer doesn't support variable parameters" | ||
| previos_format -> |
There was a problem hiding this comment.
Suggested change
| previos_format -> | |
| previous_format -> |
lib/membrane_mp4/muxer/isom.ex
Outdated
| # when stream format is duplicated - ignore | ||
| ctx.pads[pad].stream_format == stream_format -> | ||
| # Handle receiving a stream format of the same type | ||
| %^type{} -> |
There was a problem hiding this comment.
Is it OK for us to accept change from :avc3 to :avc1? Wouldn't it require appending something to the DCR?
varsill
requested changes
Aug 22, 2024
Co-authored-by: Łukasz Kita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.