-
Notifications
You must be signed in to change notification settings - Fork 0
Setup CI. Add documentation and example of usage #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/transcoder.ex
Outdated
* `Membrane.RawAudio` | ||
* `Membrane.RemoteStream{content_type: Membrane.Opus}` | ||
|
||
Please note that not all the conversions are possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What conversions are not possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H264 to AAC :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I would write that if the input stream format is audio, the output stream format must be audio as well (this same if the type is video). The way it is written right now suggests that e.g. we might not be able to transcode VP8 to H264
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, perhaps I will just remove that note, the more I think about it the more I am inclining towards conclusion that it is obvious :D
Co-authored-by: Feliks Pobiedziński <[email protected]>
Co-authored-by: Feliks Pobiedziński <[email protected]>
…scoder_plugin into setup_ci
lib/transcoder.ex
Outdated
* `Membrane.RawAudio` | ||
* `Membrane.RemoteStream{content_type: Membrane.Opus}` | ||
|
||
Please note that not all the conversions are possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I would write that if the input stream format is audio, the output stream format must be audio as well (this same if the type is video). The way it is written right now suggests that e.g. we might not be able to transcode VP8 to H264
No description provided.