Skip to content

Setup CI. Add documentation and example of usage #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Conversation

varsill
Copy link
Collaborator

@varsill varsill commented Dec 10, 2024

No description provided.

@varsill varsill requested a review from FelonEkonom December 10, 2024 10:21
* `Membrane.RawAudio`
* `Membrane.RemoteStream{content_type: Membrane.Opus}`

Please note that not all the conversions are possible!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What conversions are not possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H264 to AAC :p

Copy link
Member

@FelonEkonom FelonEkonom Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I would write that if the input stream format is audio, the output stream format must be audio as well (this same if the type is video). The way it is written right now suggests that e.g. we might not be able to transcode VP8 to H264

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, perhaps I will just remove that note, the more I think about it the more I am inclining towards conclusion that it is obvious :D

@varsill varsill requested a review from FelonEkonom December 10, 2024 16:09
* `Membrane.RawAudio`
* `Membrane.RemoteStream{content_type: Membrane.Opus}`

Please note that not all the conversions are possible!
Copy link
Member

@FelonEkonom FelonEkonom Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I would write that if the input stream format is audio, the output stream format must be audio as well (this same if the type is video). The way it is written right now suggests that e.g. we might not be able to transcode VP8 to H264

@varsill varsill requested a review from FelonEkonom December 11, 2024 10:28
@varsill varsill merged commit 993bed3 into master Dec 16, 2024
3 checks passed
@varsill varsill deleted the setup_ci branch December 16, 2024 13:48
@varsill varsill linked an issue Dec 16, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create membrane_transcoder_plugin package
2 participants