Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a ci pipeline for firmware by leoribg #285
base: master
Are you sure you want to change the base?
Setup a ci pipeline for firmware by leoribg #285
Changes from 2 commits
7c8ab47
eecf4b8
a96eca1
9095f51
5fc25be
6898734
30b713f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include the Dockerfile source with an explanation of what goes into the image- that's a crucial part of this setup and deserves a detailed explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. The Docker image is also 6GB. Would love to understand more about what's in there and what we're tell ing people they need to put in their GitHub Action CI image.
Would also be a good chance to update the Docker file to adhere to best practices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but I was trying to provide the readers a "ready to build" docker image. So they can run and build the example in minutes. The image consists of a ubuntu image with Simplicity Studio and the SDKs installed. I had to install Simplicity Studio on an Ubuntu Machine and copy the installation contents to the container to generate the image. So this is not the focus of the article. But I can try to create a docker file for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, Simplicity Studio requires login 😕 always a bit tedious when vendors do that for free toolchains.
I'd still like to have the Dockerfile detailed here; providing a pre-built one is great if someone wants to try it, but the heart of the article is about setting up such a system, rather than the actual result (eg, if someone's not using Simplicity Studio, having the Dockerfile reference is much more valuable than the pre-built image, IMO).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, understood. I will do it.