Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Practical Zephyr part 3 "Devicetree basics" #410

Merged

Conversation

lmapii
Copy link
Contributor

@lmapii lmapii commented Dec 17, 2023

Hi, this PR contains the third draft article for the article series about Zephyr. This one's about devicetree basics (semantics are part of the fourth article).

Copy link
Contributor

@ejohnso49 ejohnso49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next one is looking good! Left a lot of smaller comments, but overall another great addition. I definitely learned a decent amount with this entry.

The main point that I think might need some work is the best way to convey the types defined in the DTSpec and how they apply to Zephyr. I think my current thought is that it's easiest to connect the Format section 6.3 to the Zephyr implementation. I find the examples in this section are the easiest to map into Zephyr's types. The spec also is confusing with the prop-encoded-array term, I find it simplest to keep them as arrays of 32-bit integer cells. Any thoughts?

@ejohnso49
Copy link
Contributor

I had a hard time figuring out any conventions for Devicetree vs devicetree in the spec so I think the mixed use is fine

lmapii and others added 18 commits January 29, 2024 17:10
@lmapii
Copy link
Contributor Author

lmapii commented Jan 29, 2024

I had a hard time figuring out any conventions for Devicetree vs devicetree in the spec so I think the mixed use is fine

I did a quick pass and changed "devicetree" to "Devicetree, hope I got all of them! Now we're consistent with the Kconfig article.

@lmapii
Copy link
Contributor Author

lmapii commented Jan 29, 2024

@ejohnso49 thank you so much again for the review! I fixed the findings and applied the changes to the tables, hopefully they're a bit easier to understand now. I also removed most of the now dated <type> notations. You're completely right, there's no need for that and it's way over the top!

@ejohnso49
Copy link
Contributor

@ejohnso49 thank you so much again for the review! I fixed the findings and applied the changes to the tables, hopefully they're a bit easier to understand now. I also removed most of the now dated <type> notations. You're completely right, there's no need for that and it's way over the top!

Excellent, I will give it another review later today. Thanks!

Copy link
Contributor

@ejohnso49 ejohnso49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, thanks for the round of edits. Things are good from me 👍 , I'll let the others continue things

@lmapii
Copy link
Contributor Author

lmapii commented Jan 30, 2024

Thank you for your help @ejohnso49 !

@bahildebrand bahildebrand merged commit 1252fc4 into memfault:master Jan 31, 2024
5 checks passed
@lmapii lmapii deleted the feature/practical-zephyr-02-dts-basics branch February 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants