-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Practical Zephyr part 3 "Devicetree basics" #410
Draft: Practical Zephyr part 3 "Devicetree basics" #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next one is looking good! Left a lot of smaller comments, but overall another great addition. I definitely learned a decent amount with this entry.
The main point that I think might need some work is the best way to convey the types defined in the DTSpec and how they apply to Zephyr. I think my current thought is that it's easiest to connect the Format section 6.3 to the Zephyr implementation. I find the examples in this section are the easiest to map into Zephyr's types. The spec also is confusing with the prop-encoded-array
term, I find it simplest to keep them as arrays of 32-bit integer cells. Any thoughts?
I had a hard time figuring out any conventions for Devicetree vs devicetree in the spec so I think the mixed use is fine |
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
Co-authored-by: Eric Johnson <[email protected]>
I did a quick pass and changed "devicetree" to "Devicetree, hope I got all of them! Now we're consistent with the Kconfig article. |
@ejohnso49 thank you so much again for the review! I fixed the findings and applied the changes to the tables, hopefully they're a bit easier to understand now. I also removed most of the now dated |
Excellent, I will give it another review later today. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, thanks for the round of edits. Things are good from me 👍 , I'll let the others continue things
Thank you for your help @ejohnso49 ! |
Hi, this PR contains the third draft article for the article series about Zephyr. This one's about devicetree basics (semantics are part of the fourth article).