feat: update memfault sdk to 1.19.0 #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary
In Memfault SDK 1.19.0, the config `MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS` set via
`memfault_platform_config.h` was replaced with the Kconfig `CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS`.
This commit updates the SDK version and:
- Removes debug module Kconfig in the asset tracker app for the hearbeat interval, this is unnecessary wrapping now that the
Memfault Zephyr module has a Kconfig
- Removes references to the old config
- Adds example usage of `CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS`
### Test Plan
Confirmed successful build of asset tracker app:
```
west build -b thingy91/nrf9160/ns --sysbuild -p always nrf/applications/asset_tracker_v2 -- \
-DCONFIG_MEMFAULT_NCS_PROJECT_KEY=\"$(<~/.memfault-gilly-playground-proj-key)\" \
-DOVERLAY_CONFIG=overlay-memfault.conf
```
noahp
approved these changes
Feb 5, 2025
|
Upstream PR opened: nrfconnect#20216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Memfault SDK 1.19.0, the config
MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECSset viamemfault_platform_config.hwas replaced with the KconfigCONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECS.This commit updates the SDK version and:
heartbeat interval, this is unnecessary wrapping now that the
Memfault Zephyr module has a Kconfig
CONFIG_MEMFAULT_METRICS_HEARTBEAT_INTERVAL_SECSTest Plan
Confirmed successful build of asset tracker app:
Resolves: MCU-862