Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redis universal client in token bucket #34

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

BrianLeishman
Copy link
Contributor

Updated the client to a UniversalClient, which works for redis pools as well as single redis servers.

Updated the client to a UniversalClient, which works for redis pools as well as single redis servers.
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (50bb6c3) to head (844d499).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   83.51%   83.51%           
=======================================
  Files          10       10           
  Lines        1468     1468           
=======================================
  Hits         1226     1226           
  Misses        169      169           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@mennanov mennanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all the references to *redits.Client to redis.UniversalClient in other files too: concurrent_buffer.go, slidingwindow.go and so on.

Thanks!

@BrianLeishman
Copy link
Contributor Author

@mennanov makes sense to me, done!

@mennanov mennanov merged commit 9fa00a2 into mennanov:master Feb 28, 2024
7 checks passed
@mennanov
Copy link
Owner

Thanks for contributing!

@BrianLeishman BrianLeishman deleted the patch-1 branch February 28, 2024 22:52
@leeym leeym mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants