Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize resolver #270

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Optimize resolver #270

merged 1 commit into from
Feb 18, 2025

Conversation

goccy
Copy link
Member

@goccy goccy commented Feb 18, 2025

  • optimize register files for protoregistry
  • optimize enumAccessors

This implementation is inspired by https://github.com/protocolbuffers/protobuf-go/blob/f09e239720f1bcd654d565107b1d4feea184d552/reflect/protodesc/desc.go#L248

- optimize register files for protoregistry
- optimize enumAccessors
Copy link

Code Metrics Report

main (d8bb7aa) #270 (c302a51) +/-
Coverage 65.3% 65.3% +0.0%
Code to Test Ratio 1:0.3 1:0.3 -0.1
Test Execution Time 7m31s 7m2s -29s
Details
  |                     | main (d8bb7aa) | #270 (c302a51) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.3% |          65.3% | +0.0% |
  |   Files             |             77 |             77 |     0 |
  |   Lines             |          13763 |          13784 |   +21 |
+ |   Covered           |           8988 |           9005 |   +17 |
- | Code to Test Ratio  |          1:0.3 |          1:0.3 |  -0.1 |
  |   Code              |          42221 |          42256 |   +35 |
  |   Test              |          15816 |          15816 |     0 |
+ | Test Execution Time |          7m31s |           7m2s |  -29s |

Code coverage of files in pull request scope (83.1% → 83.1%)

Files Coverage +/-
resolver/cel.go 76.6% +1.1%
resolver/resolver.go 83.4% -0.1%

Reported by octocov

@goccy goccy merged commit 78f65b2 into main Feb 18, 2025
4 checks passed
@goccy goccy deleted the optimize branch February 18, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants