Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast process for cel plugin's list type argument #274

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

goccy
Copy link
Member

@goccy goccy commented Feb 20, 2025

Fix {"time":"2025-02-20T15:45:07.660496+09:00","level":"ERROR","msg":"internal error: interface conversion: *pluginpb.Example is not ref.Val: missing method ConvertToNative"} error

Copy link

Code Metrics Report

main (158929c) #274 (67017b2) +/-
Coverage 65.3% 65.3% -0.1%
Code to Test Ratio 1:0.3 1:0.3 -0.1
Test Execution Time 7m18s 6m55s -23s
Details
  |                     | main (158929c) | #274 (67017b2) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          65.3% |          65.3% | -0.1% |
  |   Files             |             77 |             77 |     0 |
  |   Lines             |          13796 |          13800 |    +4 |
  |   Covered           |           9017 |           9017 |     0 |
- | Code to Test Ratio  |          1:0.3 |          1:0.3 |  -0.1 |
  |   Code              |          42274 |          42279 |    +5 |
  |   Test              |          15831 |          15831 |     0 |
+ | Test Execution Time |          7m18s |          6m55s |  -23s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/-
grpc/federation/cel/plugin.go 0.0% 0.0%

Reported by octocov

@goccy goccy merged commit dba6886 into main Feb 20, 2025
4 checks passed
@goccy goccy deleted the fix-list-args branch February 20, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants