Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version text with go install #278

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix version text with go install #278

merged 1 commit into from
Mar 4, 2025

Conversation

goccy
Copy link
Member

@goccy goccy commented Mar 4, 2025

  • Use debug.ReadBuildInfo() for go install
  • Fix default version text ( dev => (devel) )
  • Add version command to protoc-gen-grpc-federation

Copy link

github-actions bot commented Mar 4, 2025

Code Metrics Report

main (b4e8f00) #278 (3e2c85a) +/-
Coverage 65.3% 65.3% +0.0%
Code to Test Ratio 1:0.3 1:0.3 +0.0
Test Execution Time 7m4s 6m54s -10s
Details
  |                     | main (b4e8f00) | #278 (3e2c85a) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          65.3% |          65.3% | +0.0% |
  |   Files             |             77 |             78 |    +1 |
  |   Lines             |          13803 |          13809 |    +6 |
+ |   Covered           |           9019 |           9024 |    +5 |
+ | Code to Test Ratio  |          1:0.3 |          1:0.3 |  +0.0 |
  |   Code              |          42413 |          42453 |   +40 |
+ |   Test              |          15913 |          15932 |   +19 |
+ | Test Execution Time |           7m4s |          6m54s |  -10s |

Code coverage of files in pull request scope (0.0% → 83.3%)

Files Coverage +/-
grpc/federation/version.go 83.3% +83.3%

Reported by octocov

@goccy goccy requested a review from Copilot March 4, 2025 09:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the version text reported by the generated gRPC federation-related files, replacing "dev" with "(devel)" to support the new installation mechanism using debug.ReadBuildInfo(), and adds a version command to the protoc-gen-grpc-federation plugin.

  • Change version text from "dev" to "(devel)" in all generated files
  • Add a version command for protoc-gen-grpc-federation

Reviewed Changes

File Description
_examples/11_multi_service/federation/other_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/16_code_gen_plugin/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/06_alias/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/01_minimum/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/05_async/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/02_simple/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/11_multi_service/federation/reaction_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/03_custom_resolver/federation/other_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/10_oneof/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/04_timeout/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/07_autobind/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/11_multi_service/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/14_condition/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/12_validation/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/13_map/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/09_multi_user/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/03_custom_resolver/federation/federation_grpc_federation.pb.go (Repeated change) Updates version text from "dev" to "(devel)"
_examples/08_literal/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/15_cel_plugin/federation/federation_grpc_federation.pb.go Updates version text from "dev" to "(devel)"
_examples/15_cel_plugin/plugin/plugin_grpc_federation.pb.go Updates version text from "dev" to "(devel)" in both file header and plugin version info

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Copy link
Member

@utahta utahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goccy goccy merged commit a6f5e1d into main Mar 4, 2025
3 checks passed
@goccy goccy deleted the fix-version branch March 4, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants