Skip to content

upgrade staticcheck-action to v1.3.0#314

Open
Deeptanshu-sankhwar wants to merge 1 commit intomeshery-extensions:masterfrom
Deeptanshu-sankhwar:fix/update-staticcheck-action
Open

upgrade staticcheck-action to v1.3.0#314
Deeptanshu-sankhwar wants to merge 1 commit intomeshery-extensions:masterfrom
Deeptanshu-sankhwar:fix/update-staticcheck-action

Conversation

@Deeptanshu-sankhwar
Copy link
Copy Markdown

@Deeptanshu-sankhwar Deeptanshu-sankhwar commented Dec 29, 2024

This PR fixes meshery/meshery#13041, upgrading dominikh/staticcheck-action@v1.2.0 to dominikh/staticcheck-action@v1.3.0

Signed commits

  • Yes, I signed my commits.

@lekaf974
Copy link
Copy Markdown

lekaf974 commented Jan 4, 2025

@Deeptanshu-sankhwar you need to signoff your commit to fix DCO

@Deeptanshu-sankhwar
Copy link
Copy Markdown
Author

Gotcha! Thanks @lekaf974 lemme recreate the PR with proper sign off.

@lekaf974
Copy link
Copy Markdown

lekaf974 commented Jan 5, 2025

Gotcha! Thanks @lekaf974 lemme recreate the PR with proper sign off.

Don't need to recreate a PR git commit --amend -s should be enough

Signed-off-by: Deeptanshu Sankhwar <deeptanshu@walletsocket.com>
@Deeptanshu-sankhwar Deeptanshu-sankhwar force-pushed the fix/update-staticcheck-action branch from 006d492 to 8cf5cdd Compare January 6, 2025 04:51
@Deeptanshu-sankhwar
Copy link
Copy Markdown
Author

Done @lekaf974, thanks a bunch! Will do the same for other PRs failing DCO as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade statichcheck-action to v1.3.0 across all repos

2 participants