Skip to content

Commit

Permalink
Merge pull request #1937 from SAHU-01/catalog_download
Browse files Browse the repository at this point in the history
[Catalog UI] Download Button Generates Incorrect File with .html Extension and Embedded HTML Content
  • Loading branch information
leecalcote authored Oct 27, 2024
2 parents cbbb338 + 5677645 commit b28a878
Showing 1 changed file with 22 additions and 17 deletions.
39 changes: 22 additions & 17 deletions _includes/copy-and-download.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,28 @@
<div class="vertical-center" id="{{type.name}}">
<div class="btn-grp">
{% if type.patternId %}
<a href="https://playground.meshery.io/extension/meshmap?mode=design&type=catalog&id={{type.patternId}}&name={{type.name}}" target="_blank" >
<button class="import" style="width: 15rem;">Open in playground </button>
<a href="https://playground.meshery.io/extension/meshmap?mode=design&type=catalog&id={{type.patternId}}&name={{type.name}}"
target="_blank">
<button class="import" style="width: 15rem;">Open in playground </button>
</a>
{% endif %}
<a href="/catalog/{{type.downloadLink}}" download>
<button id="resourceDownloadBtn" data-patternId="{{type.patternId}}" onclick="sendCloudTelemetry()" class="import" style="width: 7rem;">Download</button>

<a href="/catalog/{{type.patternId}}/{{type.publishedVersion}}/design.yml" download="{{type.name}}.yml">
<button id="resourceDownloadBtn" data-patternId="{{type.patternId}}" onclick="sendCloudTelemetry()"
class="import" style="width: 7rem;">
Download
</button>
</a>
<div class="btn-tooltip-grp">
<a class="btn tooltip-modal" data-clipboard-target="#copy-url" data-clipboard-text="{{type.URL}}"

<div class="btn-tooltip-grp">
<a class="btn tooltip-modal" data-clipboard-target="#copy-url" data-clipboard-text="{{type.URL}}"
onmouseout="resetCopyText(this)">
<button class="import" style="width: 7rem;">Copy URL
</button>
</a>
</div>


</div>
</div>
</div>
Expand All @@ -33,25 +38,25 @@
<div id="copy-url">
<div class="btn-class">
<div class="vertical-center" id="{{type.name}}">
<div class="btn-grp">
<button class="import-disabled">Download</button>
<div class="btn-tooltip-grp">
<button class="import-disabled">Copy URL</button>
<div class="btn-grp">
<button class="import-disabled">Download</button>
<div class="btn-tooltip-grp">
<button class="import-disabled">Copy URL</button>
</div>
</div>
</div>
</div></div>
</div>
</div>
{% endif %}


<script>

function sendCloudTelemetry(){
function sendCloudTelemetry() {

const element = document.getElementById("resourceDownloadBtn")
const element = document.getElementById("resourceDownloadBtn")
const patternId = element.dataset.patternid
patternId && fetch(`https://playground.meshery.io/api/pattern/download/${patternId}`)
}

</script>

</script>

0 comments on commit b28a878

Please sign in to comment.