Skip to content

fix: added validation to the Community Newsletter form #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 64 additions & 3 deletions _includes/subscribe.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
background-color: $brand-color;
text-align: center;
}

@media (min-width: 555px) and (max-width: 603px) {
.subscribe-button {
width: 100%;
Expand All @@ -49,12 +50,16 @@
id="mc-embedded-subscribe-form"
name="mc-embedded-subscribe-form"
class="validate"
onsubmit="document.getElementById(mc-embedded-subscribe-form).submit();"
onsubmit="return validateForm(event);"
>
<div id="mc_embed_signup_scroll">
<div class="subscribe-inputbox">
<input type="text" value="" placeholder="First Name" name="FNAME" class="NAME" id="mce-FNAME" required />
<input type="text" value="" placeholder="Last Name" name="LNAME" class="NAME" id="mce-LNAME" required />
<input type="text" value="" placeholder="First Name" name="FNAME" class="NAME" id="mce-FNAME" aria-label="first name input" required/>
<input type="text" value="" placeholder="Last Name" name="LNAME" class="NAME" id="mce-LNAME" aria-label="last name input" required />
</div>
<div class="subscribe-container">
<span id="mce-FNAME-error" class="subscribe-container-error"></span>
<span id="mce-LNAME-error" class="subscribe-container-error"></span>
</div>
<div id="mce-responses" class="clear subscribe-inputbox">
<div
Expand Down Expand Up @@ -94,3 +99,59 @@

<!--End mc_embed_signup-->
</div>

<script>
document.addEventListener("DOMContentLoaded", function () {

const form = document.getElementById('mc-embedded-subscribe-form');
if (form) {
form.addEventListener('submit', validateForm);
}

function validateForm(event) {
event.preventDefault();

// Clear previous error messages
clearError('mce-FNAME-error');
clearError('mce-LNAME-error');

let isValid = true;

const firstName = document.getElementById('mce-FNAME').value.trim();

if (!firstName) {
document.getElementById('mce-FNAME-error').textContent = 'First name is required.';
isValid = false;
} else if (firstName.trim().length < 2) {
document.getElementById('mce-FNAME-error').textContent = 'First Name must have at least 2 characters.';
isValid = false;
} else if (!/^[a-zA-Z]+$/.test(firstName)) {
document.getElementById('mce-FNAME-error').textContent = 'First name must only contain letters.';
isValid = false;
}

const lastName = document.getElementById('mce-LNAME').value.trim();
if (!lastName) {
document.getElementById('mce-LNAME-error').textContent = 'Last name is required.';
isValid = false;
} else if (!/^[a-zA-Z]+$/.test(lastName)) {
document.getElementById('mce-LNAME-error').textContent = 'Last name must only contain letters.';
isValid = false;
}

if (isValid) {
form.submit();
}
}

function clearError(errorId) {
const errorElement = document.getElementById(errorId);
if (errorElement) {
errorElement.textContent = '';
}
}

document.getElementById('mce-FNAME').addEventListener('input', () => clearError('mce-FNAME-error'));
document.getElementById('mce-LNAME').addEventListener('input', () => clearError('mce-LNAME-error'));
});
</script>
17 changes: 17 additions & 0 deletions _sass/forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,21 @@ input[type=text]:focus, input[type=email]:focus, input[type=password]:focus, tex

.subscribe-inputbox{
padding-left: 0px !important;
}

.subscribe-container{
color: red;
display: grid;
grid-template-columns: 1fr 1fr;
gap: 1rem;
padding-top: 5px;
text-align: start;
}


.subscribe-container-error{
display: block;
font-size: 0.875rem;
padding-left: 2px;
line-height: 1.2;
}
Loading