feat: Add Page X of Y indicator to pagination controls#2564
feat: Add Page X of Y indicator to pagination controls#2564TarunyaProgrammer wants to merge 8 commits intomeshery:masterfrom
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @TarunyaProgrammer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience of the catalog pagination by introducing a "Page X of Y" indicator. This client-side enhancement provides users with immediate context about their current position within large result sets and the total number of available pages, addressing a previous limitation where only "Prev" and "Next" buttons were present. The changes are purely frontend, integrating seamlessly with existing pagination logic. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully adds a page indicator to the catalog pagination, which is a great usability improvement. The implementation is straightforward and correctly handles the client-side logic. I have one suggestion to make the JavaScript selector more robust and maintainable.
Signed-off-by: Tarunya K <tarunya.programmer@gmail.com>
a4f02df to
f0a234e
Compare
|
@meshery/maintainers |
|
@TarunyaProgrammer Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Signed-off-by: Tarunya K <84562027+TarunyaProgrammer@users.noreply.github.com>
|
@kishore08-07 kindly review the PR when convenient. Thanks! |
|
@TarunyaProgrammer Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@TarunyaProgrammer Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Add page indicator to catalog pagination (Page X of Y)
What this PR does
This PR adds a page indicator to the catalog pagination UI to display the current page and total number of pages (e.g.,
Page 2 of 6).The enhancement improves navigation clarity while keeping pagination entirely client-side.
Problem
The catalog pagination on https://meshery.io/catalog/designs currently only provides “Prev” and “Next” buttons.
As a result, users cannot:
This makes navigation less intuitive, especially when browsing large result sets.
Solution
Page X of Y) in the pagination UI.Implementation details
matchingCards.lengthitemsPerPage_includes/patterns-filter.html.This ensures accuracy even when the result set changes due to filtering.
Screenshots
Before: Pagination shows only “Prev” / “Next”
Before.Meshery-1.mov
After: Pagination displays
Page X of Ybetween navigation buttonsAfter.Meshery-1.mov
Related Issue
Closes #2563
Checklist