Conversation
- Changed primary button to saffron yellow (#E0C077) - Changed secondary button to keppel green (#00b39f) - Added tertiary button with transparent background Signed-off-by: Aditya Tiwari <phoenixcodeforces@gmail.com>
Signed-off-by: Awanish Tripathi <phoenixcodeforces@gmail.com>
Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @bhavyamsharmaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the styling of various buttons across the application to introduce distinct visual feedback on hover. It defines specific color transitions for primary, secondary, and tertiary button types, enhancing the user experience by making interactive elements more responsive and intuitive. The changes ensure a consistent and modern look for button interactions. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully implements the requested button hover effects and color updates. However, there is a discrepancy between the PR description and the implementation for the 'Download' buttons, which are currently using the green secondary style instead of the saffron primary style. Additionally, the tertiary button's white text on a transparent background may cause visibility issues on light-themed pages. Some minor CSS style inconsistencies were also noted.
|
"Hey @saurabhraghuvanshii @Rajesh-Nagarajan-11, Submitting this fresh PR to wrap up the stale issue. I’ve implemented the missing hover states and fixed the color variables you asked for previously. Ready for a look when you have a moment! |
- Change Download buttons to use primary .import class - Update tertiary button text color to #00b39f for visibility - Fix SCSS formatting (spacing around >) Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
|
@bhavyamsharmaa Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
4 participants
Fixed #2389
###What does this PR do?
=>Normal: Saffron Yellow (#E4A624)
=>Hover: Darker Saffron (#c98d0f) for visual feedback.
2 . Secondary Button (Download - Alternate)
=>Normal: Keppel Green (#00b39f)
=>Hover: Darker Green (#008a7a).
3.Tertiary Button (Quick Start)
=>Normal: Transparent background with a Green border.
=>Hover: Adds a subtle Light Green Tint (rgba(0, 179, 159, 0.1)) instead of filling it with a solid color, keeping it distinct from the secondary button