fix(ui): correct media query scope in program.css#2586
fix(ui): correct media query scope in program.css#2586bhavyamsharmaa wants to merge 9 commits intomeshery:masterfrom
Conversation
- Changed primary button to saffron yellow (#E0C077) - Changed secondary button to keppel green (#00b39f) - Added tertiary button with transparent background Signed-off-by: Aditya Tiwari <phoenixcodeforces@gmail.com>
Signed-off-by: Awanish Tripathi <phoenixcodeforces@gmail.com>
Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
- Change Download buttons to use primary .import class - Update tertiary button text color to #00b39f for visibility - Fix SCSS formatting (spacing around >) Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
Fixes a layout issue where .project-details and .community-details were outside the mobile media query block. This ensures these elements correctly take full width on smaller screens. Fixes: meshery#2585 Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @bhavyamsharmaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses a critical CSS media query scoping issue that was preventing responsive styles from applying correctly to certain UI elements. In addition to this fix, it refines the styling of various buttons across the application, introducing a new tertiary button style and enhancing existing ones for a more cohesive user interface. The changes also include general code formatting improvements to boost maintainability. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily fixes a CSS syntax error in program.css by removing a misplaced closing brace. It also includes extensive formatting cleanups and refactors button styles in _sass/catalog.scss, applying these new styles in _includes/models/modal.html and _layouts/single-page-model.html. The changes improve code quality and fix the intended bug. I've made a couple of minor suggestions to add missing newlines at the end of files, which is a standard best practice.
Fixes a layout issue where .project-details and .community-details were outside the mobile media query block. This ensures these elements correctly take full width on smaller screens. Fixes: meshery#2585 Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
…amsharmaa/meshery.io into fix/program-css-layout-bug
Signed-off-by: Bhavyam <positionbhavyamsharma@gmail.com>
|
@Bhumikagarggg will you review? |
|
@bhavyamsharmaa Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
5 participants
Description
This PR fixes a CSS syntax error where the closing brace for a media query @media screen and (max-width: 640px)\ was misplaced. This caused the .project-details\ and .community-details\ rules to fall outside the media query.
Changes:
Fixes: #2585
Signed-off-by
Signed-off-by: Bhavya Sharma bhavyamsharmaa@gmail.com