ENH: add support for symbolic links in package repository #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
sdist-symlinks
branch
2 times, most recently
from
ef8925e to
9ac7f0a
Compare
rgommers
reviewed
Apr 24, 2025
There was a problem hiding this comment.
Thanks @dnicolodi, this looks pretty good to me. The one thing I'd suggest is to emit warnings for symlinks that get ignored, rather than silently skipping over them. Something like:
WARNING: symlink pointing outside package ignored: symlinks-1.0.0/baz.py
WDYT?
|
I think the warning is a good idea. Probably it is a good idea to warn also for other archive members that are not handled: anything that is not a file and symbolic links to directories even if withing the archive. The reason for not adding the warning was that the latest release that (accidentally) supported symlinks didn't warn either. I'll add the warnings. |
dnicolodi
force-pushed
the
sdist-symlinks
branch
3 times, most recently
from
de51b39 to
4365161
Compare
|
Warnings added. |
Symbolic links are included as regular files in the sdist archive. Only symbolic links pointing to files withing the archive are supported.
dnicolodi
force-pushed
the
sdist-symlinks
branch
from
4365161 to
8a59030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolic links are included as regular files in the sdist archive. Only symbolic links pointing to files withing the archive are supported. Replaces #713.