Allow client_tools
to be defined only once
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to address an issue I noticed where
client_tools
has to be declared twice in two different way in order to work properly. It has to be declared in theAgentConfig
with something liketool.get_tool_definition()
, as well as in theAgent
. See the example below.This PR updates the
Agent
class initialization to setagent_config["client_tools"]
based on theAgent
class'sclient_tools
parameter so that the user only needs to declareclient_tools
once and not worry about the.get_tool_definition()
list comprehension.Test Plan
I've confirmed that these code changes work as expected using the
llamastack/distribution-ollama:latest
image as the local Llama Stack server. You can run the code snippet below to verify.You should see an output below that has correctly called the CustomTool.