TCPBuffer #753
Open
TCPBuffer #753
+596
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
force-pushed
the
export-D79588454
branch
from
225c54c to
7020c0b
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
dulinriley
pushed a commit
to dulinriley/monarch
that referenced
this pull request
Aug 5, 2025
Summary: Pull Request resolved: meta-pytorch#644 1.10.1 (March 5th, 2025) Fixed Fix memory leak when using to_vec with Bytes::from_owner (meta-pytorch#773) 1.10.0 (February 3rd, 2025) Added Add feature to support platforms without atomic CAS (meta-pytorch#467) try_get_* methods for Buf trait (meta-pytorch#753) Implement Buf::chunks_vectored for Take (meta-pytorch#617) Implement Buf::chunks_vectored for VecDeque<u8> (meta-pytorch#708) Fixed Remove incorrect guarantee for chunks_vectored (meta-pytorch#754) Ensure that tests pass under panic=abort (meta-pytorch#749) Reviewed By: cjlongoria Differential Revision: D78948561 fbshipit-source-id: bb755e25088f9d77f0d5a9ae3027cadc51ea586a
allenwang28
force-pushed
the
export-D79588454
branch
from
7020c0b to
f3b8347
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 7, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 7, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
f3b8347 to
ec7c233
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
force-pushed
the
export-D79588454
branch
from
ec7c233 to
d335c89
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 7, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
force-pushed
the
export-D79588454
branch
from
d335c89 to
84274e7
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 8, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 8, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
84274e7 to
08c60fc
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 8, 2025
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
08c60fc to
15aa315
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: meta-pytorch#753 X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
15aa315 to
72fc26d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Aug 8, 2025
Summary: Pull Request resolved: meta-pytorch#753 X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
72fc26d to
2ca2e76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
Summary: X-link: meta-pytorch#753 Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer. The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added Differential Revision: D79588454
allenwang28
force-pushed
the
export-D79588454
branch
from
2ca2e76 to
159052c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79588454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a TCPBuffer implementation to tensor_engine, as a fallback example for RDMABuffer.
The main change from the original TCP-based buffer is that it uses ZMQ for communications to 1) decouple from Monarch's message passing system and 2) to mimic RDMABuffer's design, and showcase how other backends can be easily added
Differential Revision: D79588454