Semi-private python API for overriding handle_undeliverable_message inside PythonActor #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79841379 |
samlurye
force-pushed
the
export-D79841379
branch
from
ffee376 to
a8f0684
Compare
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 7, 2025
…nside PythonActor (meta-pytorch#797) Summary: This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 7, 2025
…nside PythonActor (meta-pytorch#797) Summary: This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
force-pushed
the
export-D79841379
branch
from
a8f0684 to
0b2ff30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79841379 |
samlurye
force-pushed
the
export-D79841379
branch
from
0b2ff30 to
ded93a6
Compare
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 7, 2025
…nside PythonActor (meta-pytorch#797) Summary: Pull Request resolved: meta-pytorch#797 This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
|
This pull request was exported from Phabricator. Differential Revision: D79841379 |
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 7, 2025
…nside PythonActor (meta-pytorch#797) Summary: Pull Request resolved: meta-pytorch#797 This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
force-pushed
the
export-D79841379
branch
from
ded93a6 to
7ff7f9d
Compare
Summary: The purpose of this diff is to handle the following scenario: 1. Process A starts serving a NetRx. 2. Process B creates a NetTx that connects to process A's NetRx. 3. B sends a few messages to A, and the messages are acked. 4. Process A dies/is killed, while B stays alive. 5. A new Process C starts serving a NetRx on the same channel as from step 1. 6. B's NetTx connects to C's NetRx, *with no way of knowing it has connected to a different process than before*. 7. B sends messages to C, starting from where it left off with A. 8. C rejects all of B's messages because of invalid sequence numbers. 9. B's NetTx eventually times out after a long time with no acks. In order to distinguish among connections from different NetTx instances to the same NetRx instance, each NetTx generates a random unique session id. This session id gets sent as part of an initial handshake from NetTx -> NetRx before the NetTx starts sending normal messages. Currently, though, NetTx doesn't wait for any handshake before starting to send messages. To resolve the issue described above, this diff introduces a global (per-process) "rx session id". When a NetTx first connects to a NetRx, the NetRx responds with its rx session id as part of the handshake. The NetTx waits for the handshake response and extracts the rx session id. If this is the first time the NetTx is connecting, the NetTx stores the rx session id. On subsequent connection attempts, the NetTx will validate the rx session id it receives from the handshake against the rx session id it previously stored; if there is a mismatch, the NetTx returns the appropriate error to its caller. Differential Revision: D79607092
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 8, 2025
…nside PythonActor (meta-pytorch#797) Summary: This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
force-pushed
the
export-D79841379
branch
from
7ff7f9d to
1d8b449
Compare
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 8, 2025
…nside PythonActor (meta-pytorch#797) Summary: This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
force-pushed
the
export-D79841379
branch
from
1d8b449 to
ea4e5c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D79841379 |
samlurye
pushed a commit
to samlurye/monarch-1
that referenced
this pull request
Aug 8, 2025
…nside PythonActor (meta-pytorch#797) Summary: Pull Request resolved: meta-pytorch#797 This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
samlurye
force-pushed
the
export-D79841379
branch
from
ea4e5c8 to
0766c30
Compare
…nside PythonActor (meta-pytorch#797) Summary: Pull Request resolved: meta-pytorch#797 This diff makes undeliverable message handling overridable for python actors, using the newly introduced `Actor._handle_undeliverable_message` method. Previously, the rust implementation of `PythonActor` simply used the default `Actor::handle_undeliverable_message` implementation. Now, `PythonActor` overrides `handle_undeliverable_message` to call into the corresponding method on the underlying python class. Differential Revision: D79841379
|
This pull request was exported from Phabricator. Differential Revision: D79841379 |
samlurye
force-pushed
the
export-D79841379
branch
from
0766c30 to
2615b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff makes undeliverable message handling overridable for python actors, using the newly introduced
Actor._handle_undeliverable_messagemethod. Previously, the rust implementation ofPythonActorsimply used the defaultActor::handle_undeliverable_messageimplementation. Now,PythonActoroverrideshandle_undeliverable_messageto call into the corresponding method on the underlying python class.Differential Revision: D79841379